任务单 #18740

Check return codes everywhere

开放日期: 2009-09-17 01:58 最后更新: 2009-10-06 22:29

报告人:
属主:
(无)
状态:
开启
组件:
(无)
里程碑:
(无)
优先:
3
严重性:
5 - Medium
处理结果:
Postponed
文件:
Vote
Score: 0
No votes
0.0% (0/0)
0.0% (0/0)

Details

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "WriteFile" like in the function "CommentLogToFile" and from "GetModuleFileName" in the function "GetUILanguageFile"?

任务单历史 (3/7 Histories)

2009-09-17 01:58 Updated by: elfring
  • New Ticket "Check return codes everywhere" created
2009-09-26 11:56 Updated by: (del#1144)
评论

How do you think a user hope which behavior?

(1) check the error and pop up MessageBox(modal), interrupt user operation.
(2) check the error and not notify to user.

2009-09-26 18:56 Updated by: elfring
评论

Situations might happen where users can not be notified about the unexpected "thing" by a message box.

Usual software design options are described in the article "Exception Handling Alternatives" by Detlef Vollmann.

I suggest to avoid unchecked function calls. Would you like to detect every error situation as early as possible?

2009-09-29 12:18 Updated by: (del#1144)
评论

I read your suggestion as "detect every error at every function call."

It is in the right. And it takes labor and time to check them.

2009-09-29 19:05 Updated by: elfring
评论

You do not need to make assumptions about error situations. Please check all error codes. Otherwise, it might not be noticed if anything unexpected went wrong.

Would you like to reduce the efforts for error code checking by an exception class hierarchy?

2009-10-06 22:28 Updated by: (del#1144)
  • 类型 Update from Bugs to Feature Requests
  • 优先 Update from 5 - Medium to 3
2009-10-06 22:29 Updated by: (del#1144)
  • 处理结果 Update from to Postponed

Attachment File List

No attachments

编辑

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登录名